feat(sig): Report list toolbar as core control#1532
Open
Twixes wants to merge 1 commit intotwix/inbox-row-visualsfrom
Open
feat(sig): Report list toolbar as core control#1532Twixes wants to merge 1 commit intotwix/inbox-row-visualsfrom
Twixes wants to merge 1 commit intotwix/inbox-row-visualsfrom
Conversation
This was referenced Apr 7, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Twixes
force-pushed
the
twix/inbox-row-visuals
branch
from
c53762d to
f96bd7a
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
67f9a59 to
af669e3
Compare
Twixes
force-pushed
the
twix/inbox-row-visuals
branch
from
f96bd7a to
3971708
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
af669e3 to
0e246ba
Compare
Twixes
changed the title
Twixes
force-pushed
the
twix/inbox-row-visuals
branch
from
3971708 to
ae4d475
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
0e246ba to
8f8f5fb
Compare
Twixes
force-pushed
the
twix/inbox-row-visuals
branch
from
ae4d475 to
57e72a2
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
8f8f5fb to
200faf9
Compare
oliverb123
force-pushed
the
twix/inbox-row-visuals
branch
from
57e72a2 to
8e02e34
Compare
oliverb123
force-pushed
the
twix/inbox-selection-ux
branch
from
200faf9 to
7f9bc81
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
7f9bc81 to
ea177bc
Compare
Twixes
force-pushed
the
twix/inbox-row-visuals
branch
from
8e02e34 to
da7746d
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
ea177bc to
e0e00eb
Compare
Twixes
changed the title
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
e0e00eb to
5a7e2ab
Compare
Twixes
force-pushed
the
twix/inbox-row-visuals
branch
from
da7746d to
41031df
Compare
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
5a7e2ab to
5fb9697
Compare
Made-with: Cursor
Twixes
force-pushed
the
twix/inbox-selection-ux
branch
from
5fb9697 to
7b212dd
Compare
sortafreel
approved these changes
Apr 8, 2026
oliverb123
approved these changes
Apr 8, 2026
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inbox list toolbar introduced in #1513 added controls only for bulk operations. But the same controls have been missing for individual reports too. In the Cloud version, we had them under a dropdown in the report pane itself. I considered doing the same here, but there's no point when we have a great toolbar - the toolbar should be the individual report controls as well.
At the same time, checkboxes take away from the content when shown always - and we don't need them by default for most user interactions here. (Ofc will validate this, but at least I think that's a safe assumption for now that the individual report level is the primary one.)
Changes
Making the report list toolbar always-on, with intuitive logic for selection state synced with the currently-viewed-report state. Unifies the selection state, so that "currently viewed" and "selected" are the same thing. Checkboxes only show up when multiple reports are selected. For multi-select, you can use the "Select all" checkbox or standard desktop Shift/Cmd+click patterns. See in action: